🌱 Rename referencedResources and dependentResources #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdbooth
force-pushed
the
machineresources
branch
from
9e0c8b7
to
f271544
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
mdbooth
force-pushed
the
machineresources
branch
from
f271544
to
b568ddc
Compare
k8s-ci-robot
removed
lgtm
1 task
mdbooth
force-pushed
the
machineresources
branch
2 times, most recently
from
df669a3
to
ada7741
Compare
The intent of this structure is to hold all OpenStack resources created for the machine, including the server. 'dependent' was redundant.
This struct has already moved beyond external references, and seems be evolving towards a fully-resolved machine spec. For want of a better name we call it 'resolved', which is more accurate.
mdbooth
force-pushed
the
machineresources
branch
from
ada7741
to
5d11950
Compare
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rename. It contains no functional code changes.
referencedResourcesbecomesresolved. It is a set of fully resolved intents based on the spec and the environment.dependentResourcesbecomesresourcesbecause it's a collection of OpenStack resources, anddependentwas redundant.TODO:
/hold