-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default cloud usage when cloudsSecret is absent #197
Fix default cloud usage when cloudsSecret is absent #197
Conversation
When cloudsSecret is not specified in machine's provider config, currently provider segfaults because CloudsSecret is nil and we try to access Namespace field from it. Add a guard to ignore secret if it is nil or name is empty.
Hi @YorikSar. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm Works on my cluster |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaosaffe, YorikSar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When cloudsSecret is not specified in machine's provider config,currently provider segfaults because CloudsSecret is nil and we try to access Namespace field from it. Add a guard to ignore secret if it is nil or name is empty.
Release note: