⚠️ Move InstanceID from Spec to Status #1988
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdbooth
force-pushed
the
instanceidstatus2
branch
2 times, most recently
from
75e2bb0
to
a6b46de
Compare
mdbooth
force-pushed
the
instanceidstatus2
branch
from
a6b46de
to
5c1ad44
Compare
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
| @@ -119,6 +118,10 @@ type OpenStackMachineStatus struct { | |||
| // +optional | |||
| Ready bool `json:"ready"` | |||
|
|
|||
| // InstanceID is the OpenStack instance ID for this machine. | |||
| // +optional | |||
| InstanceID optional.String `json:"instanceID,omitempty"` | |||
There was a problem hiding this comment.
Have we considered adding it under the Resolved field?
There was a problem hiding this comment.
My first PR put it in Resources. This made sense, but I've decided against that for now. The reason is I think InstanceID is fundamental to the OpenStackMachine object and something an end user might be interested in (e.g. in printcolumns), but the other properties are not.
I have an idea that I might move actual machine creation into a separate controller with its own CRD, in which case Resources would move to the new controller. In that case I think we'd still want InstanceID to be on this object, so I decided to put it here instead.
None of which precludes adding it to Resources in the future too if it turns out that still makes sense.
|
/lgtm looks good |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This is a status field and should not be included in the spec. ProviderID is the same, but cannot be removed as it is required by Cluster API.
This PR replaces #1961 with a smaller scope.
TODO:
restorev1alpha6MachineTemplateMachineSpecinto 🐛 Fix multiple panics in restore functions #1989/hold