Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump version artifacts for release-0.10 #1994

Merged
merged 1 commit into from
Apr 2, 2024
Merged

🌱 Bump version artifacts for release-0.10 #1994

merged 1 commit into from
Apr 2, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Apr 2, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit ed829b3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660c13b96f041e0008944702
😎 Deploy Preview https://deploy-preview-1994--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

Looks good, but I wonder why it's needed now and not on 0.10 release.

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 2, 2024 •
edited

Looks good, but I wonder why it's needed now and not on 0.10 release.

It will be needed on main as soon as a v0.10 tag is created due to the way we generate version numbers and clusterctl gets metadata.

If we tag v0.10 without this it won't be possible to deploy it with clusterctl. As soon as we do tag it, it will also be required on main, so we might as well merge it in main and push to the release branch.

@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@mdbooth mdbooth mentioned this pull request Apr 2, 2024
Merged
@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 79fcb6a into kubernetes-sigs:main Apr 2, 2024
8 of 9 checks passed
@mdbooth mdbooth deleted the v10-metadata branch April 2, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdbooth @k8s-ci-robot @dulek