Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump k8s dep to 0.29.3 #2014

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Apr 11, 2024

This deprecates k8s.io/util/pointer, which we replace with k8s.io/util/ptr to keep the linter happy.

The primary driver for this is to merge the pointer->ptr update without waiting for CAPI v1.7 to be released so we can merge #2012.

/hold

This deprecates k8s.io/util/pointer, which we replace with
k8s.io/util/ptr to keep the linter happy.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit d04c4d5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/661815ea2efa2d00084e9c5e
😎 Deploy Preview https://deploy-preview-2014--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth mdbooth mentioned this pull request Apr 11, 2024
1 task
@huxcrux
Copy link
Contributor

huxcrux commented Apr 11, 2024

/lgtm

Nice to get rid of all deprecation warnings :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@jichenjc
Copy link
Contributor

/approve
/hold cancel

nice clean up

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 639ca12 into kubernetes-sigs:main Apr 12, 2024
9 checks passed
@mdbooth mdbooth deleted the pointer-to-ptr branch April 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants