Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1alpha2 Migration] add v1alpha2 types #445

Closed

Conversation

@sbueringer
Copy link
Contributor

commented Aug 17, 2019

This PR is the first step via ClusterAPI v1alpha2. It only creates the new v1alpha2 types in the old kubebuilder structure. See #380 (comment) for more details.

This PR doesn't:

  • break any v1alpha1 behavior
  • touch the machine/cluster actuator
  • upgrade to kubebuilder v2

Types have been generated via:

kubebuilder create api --group infrastructure --version v1alpha2 --kind OpenStackCluster
kubebuilder create api --group infrastructure --version v1alpha2 --kind OpenStackMachine
@sbueringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

/assign @jichenjc
/assign @hidekazuna

@sbueringer sbueringer changed the title add v1alpha2 types [v1alpha2 Migration] add v1alpha2 types Aug 17, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 17, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbueringer
To complete the pull request process, please assign jichenjc
You can assign the PR to them by writing /assign @jichenjc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer added 3 commits Aug 17, 2019
@jichenjc

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

to make it easier for mergeing
#447 backport code from master to rlease 0.1
and
#448 add hint on relase0.1 branch

so we can start to merge code into master now...

@sbueringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

I'm not sure if I should just close this PR. #446 already supersedes it. And I guess its easier to just review the final CRDs.

@jichenjc What do you think?

@jichenjc

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

yeah, I agree it will be easier to check only one PR and do local try as well..thanks

@sbueringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

/close

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 20, 2019

@sbueringer: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the sbueringer:pr-add-v1alpha2-types branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.