Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cluster-api to 0.3.9 #639

Merged
merged 1 commit into from Oct 10, 2020
Merged

update cluster-api to 0.3.9 #639

merged 1 commit into from Oct 10, 2020

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build failed.

@prankul88
Copy link
Contributor

prankul88 commented Sep 24, 2020 •
edited

@jichenjc CAPI v0.3.10 is due for release this month end or early Oct.
Can we update this to v0.3.9 and probably push another patch for v0.3.10

Whatever you think might work the best :)

@jichenjc jichenjc changed the title WIP: update cluster-api to 3.10 WIP: update cluster-api to 0.3.9 Sep 24, 2020
@jichenjc
Copy link
Contributor Author

@prankul88 thanks for the comments, updated

@jichenjc jichenjc changed the title WIP: update cluster-api to 0.3.9 update cluster-api to 0.3.9 Sep 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2020
@jichenjc
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-test

@prankul88
Copy link
Contributor

@jichenjc Looks good. Let's wait for the tests 👍

@prankul88
Copy link
Contributor

Sorry didnt see the tests already failed. Will check this in my local.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 24, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@jichenjc
Copy link
Contributor Author

@prankul88 I think the previous failed test pass now :)

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 25, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@jichenjc
Copy link
Contributor Author

@prankul88 please help to check again :)

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 30, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 30, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 30, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 30, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 30, 2020

Build failed.

hidekazuna
hidekazuna reviewed Oct 1, 2020
View reviewed changes
Makefile Outdated
@@ -335,7 +337,7 @@ create-cluster: $(CLUSTERCTL) $(KUSTOMIZE) $(ENVSUBST) ## Create a development K

# (Re-)install Core providers
$(CLUSTERCTL) delete --all
$(CLUSTERCTL) init --core cluster-api:v0.3.8 --bootstrap kubeadm:v0.3.8 --control-plane kubeadm:v0.3.8
$(CLUSTERCTL) init --core cluster-api:v${CAPI_VERSION} --bootstrap kubeadm:v${CAPI_VERSION} --control-plane kubeadm:v${CAPI_VERSION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may be able to avoid the latest acceptance-test error by combining l340 and l345 into l345.

$(CLUSTERCTL) init --config ./out/clusterctl.yaml --infrastructure openstack --core cluster-api:v${CAPI_VERSION} --bootstrap kubeadm:v${CAPI_VERSION} --control-plane kubeadm:v${CAPI_VERSION}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure... let's give a try :)

@hidekazuna
Copy link
Contributor

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 4, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Oct 9, 2020

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 9, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 9, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 10, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 10, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 10, 2020

Build succeeded.

@jichenjc
Copy link
Contributor Author

@hidekazuna can you help to merge this ?
And we need fix our CI (around 20% pass ratio now ...)

@hidekazuna
Copy link
Contributor

/lgtm

Though CAPI v0.3.10 has been already released.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3660232 into kubernetes-sigs:master Oct 10, 2020
@prankul88
Copy link
Contributor

Though CAPI v0.3.10 has been already released.

@hidekazuna I will push a patch for capi v0.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidekazuna hidekazuna hidekazuna left review comments

@prankul88 prankul88 prankul88 left review comments

@iamemilio iamemilio Awaiting requested review from iamemilio

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@hidekazuna hidekazuna

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jichenjc @k8s-ci-robot @prankul88 @hidekazuna