Fix LoadBalancerMember creation #737
Conversation
When creating loadbalancer member, subnet not found error occurred. This commit fixes it. If subnet is not given, LBaaS uses the vip_subnet_id parameter value for the subnet UUID.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
@sbueringer @jichenjc PTAL |
|
@hidekazuna can you create an issue about this ? |
I Raised #738, also updated the PR comment.
Yes. more precisely, create LBMember case.
You can not add multiple subnets for CreateMember parameter. |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
| @@ -268,7 +267,6 @@ func (s *Service) ReconcileLoadBalancerMember(clusterName string, machine *clust | |||
| Name: name, | |||
| ProtocolPort: port, | |||
| Address: ip, | |||
There was a problem hiding this comment.
So just that I get it right. Instead of setting the correct subnet (which is invisible to Octavia) we don't set it but Octavia then chooses to subnet automatically? (and I guess it chooses the one we would set)
(fyi, OpenStack cloud controller manager also sets the subnet id, but only if it's configured in the cloud.conf)
There was a problem hiding this comment.
Yes. If you omit the subnet_id parameter, the vip_subnet_id for the parent load balancer will be used for the member subnet UUID.
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-member-detail#create-member
There was a problem hiding this comment.
Sounds good, thx for the info
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hidekazuna, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@hidekazuna For me it would be okay to merge, so I can also give you a lgtm. Wdyt? |
It is good to me. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
Currently subnet argument is given when creating load balancer member. it causes error.
This PR removes subnet argument so that LBaaS uses the vip_subnet_id parameter value for the subnet UUID
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #738
Special notes for your reviewer:
We follow Deploy a basic HTTP load balancer using a floating IP model. The subnet for lb members equals to vip_subnet_id in this case.
Release note: