Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add webhook readiness and health checks #955

Merged
merged 1 commit into from Jul 28, 2021
Merged

✨ Add webhook readiness and health checks #955

merged 1 commit into from Jul 28, 2021

Conversation

tobiasgiese
Copy link
Member

Signed-off-by: Tobias Giese tobias.giese@daimler.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #954

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum

@tobiasgiese
add webhook readiness and health check
7baf471 
Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @tobiasgiese. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2021
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
chrischdi
chrischdi reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chrischdi
Copy link
Member

/retitle ✨ Add webhook readiness and health check

@k8s-ci-robot k8s-ci-robot changed the title ✨ add webhook readiness and health check ✨ Add webhook readiness and health check Jul 28, 2021
@chrischdi
Copy link
Member

/retitle sparkles Add webhook readiness and health checks

@k8s-ci-robot k8s-ci-robot changed the title ✨ Add webhook readiness and health check sparkles Add webhook readiness and health checks Jul 28, 2021
@chrischdi
Copy link
Member

/retitle ✨ Add webhook readiness and health checks

@k8s-ci-robot k8s-ci-robot changed the title sparkles Add webhook readiness and health checks ✨ Add webhook readiness and health checks Jul 28, 2021
@jichenjc
Copy link
Contributor

/approve

/hold cancel

already 2 lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 25baa6c into kubernetes-sigs:master Jul 28, 2021
@tobiasgiese tobiasgiese deleted the tobiasgiese/webhook-health-check branch July 28, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@hidekazuna hidekazuna Awaiting requested review from hidekazuna

Assignees

@chrischdi chrischdi

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add webhook health check
4 participants
@tobiasgiese @k8s-ci-robot @jichenjc @chrischdi