-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add conformance tests #205
Conversation
@@ -54,7 +54,7 @@ providers: | |||
files: | |||
- sourcePath: "../../../metadata.yaml" | |||
targetName: "metadata.yaml" | |||
- sourcePath: "../../../templates/cluster-template.yaml" | |||
- sourcePath: "../../../templates/cluster-template-ci.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was wrong from the previous PR that added the e2e, this is the correct template to use.
b8d4334
to
e9bfd6a
Compare
got this in the github action
|
e9bfd6a
to
b17bd11
Compare
b17bd11
to
32f7748
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add Conformance tests
final logs
/assing @detiber @gianarb
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #199