Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add conformance tests #205

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 17, 2020

What this PR does / why we need it:
Add Conformance tests

final logs

[1] JUnit report was created: /output/junit_kubetest.01.xml
[1] {"msg":"Test Suite completed","total":277,"completed":277,"skipped":4715,"failed":0}
[1]
[1] Ran 277 of 4992 Specs in 6261.777 seconds
[1] SUCCESS! -- 277 Passed | 0 Failed | 0 Flaked | 0 Pending | 4715 Skipped
[1] PASS
[1]
[1] Ginkgo ran 1 suite in 1h44m23.372639431s
[1] Test Suite Passed
[1] [AfterEach] Conformance Tests
[1]   /Users/cpanato/go/src/sigs.k8s.io/cluster-api-provider-packet/test/e2e/conformance_test.go:114
[1] STEP: Dumping all the Cluster API resources in the "conformance-tests-fqivty" namespace
[1] STEP: Deleting cluster conformance-tests-fqivty/capp-conf-1gmu5f
[1] STEP: Deleting cluster capp-conf-1gmu5f
[1] INFO: Waiting for the Cluster conformance-tests-fqivty/capp-conf-1gmu5f to be deleted
[1] STEP: Waiting for cluster capp-conf-1gmu5f to be deleted
[1] STEP: Deleting namespace used for hosting the "conformance-tests" test spec
[1] INFO: Deleting namespace conformance-tests-fqivty
[1] STEP: Making sure there is no leftover running for capp-conf-1gmu5f
[1] STEP: Redacting sensitive information from logs
[1]
[1] • [MEASUREMENT]
[1] Conformance Tests
[1] /Users/cpanato/go/src/sigs.k8s.io/cluster-api-provider-packet/test/e2e/conformance_test.go:39
[1]   conformance-tests
[1]   /Users/cpanato/go/src/sigs.k8s.io/cluster-api-provider-packet/test/e2e/conformance_test.go:69
[1]
[1]   Ran 1 samples:
[1]   cluster creation:
[1]     Fastest Time: 793.188s
[1]     Slowest Time: 793.188s
[1]     Average Time: 793.188s ± 0.000s
[1]   conformance suite:
[1]     Fastest Time: 6302.659s
[1]     Slowest Time: 6302.659s
[1]     Average Time: 6302.659s ± 0.000s
[1]   conformance suite run time:
[1]     Smallest: 6302.659
[1]      Largest: 6302.659
[1]      Average: 6302.659 ± 0.000
[1] ------------------------------
[1] STEP: Tearing down the management cluster
[1]
[1] JUnit report was created: /Users/cpanato/go/src/sigs.k8s.io/cluster-api-provider-packet/_artifacts/junit.e2e_suite.1.xml
[1]
[1] Ran 1 of 3 Specs in 7348.982 seconds
[1] SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2 Skipped
[1] PASS

/assing @detiber @gianarb

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #199

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2020
@@ -54,7 +54,7 @@ providers:
files:
- sourcePath: "../../../metadata.yaml"
targetName: "metadata.yaml"
- sourcePath: "../../../templates/cluster-template.yaml"
- sourcePath: "../../../templates/cluster-template-ci.yaml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was wrong from the previous PR that added the e2e, this is the correct template to use.

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

got this in the github action

Error: Unable to process command '::set-env name=KUBEBUILDER_DIR::/tmp/kubebuilder_install' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

@cpanato
Copy link
Member Author

cpanato commented Feb 19, 2021

ping @detiber @gianarb we still want this?

@displague
Copy link
Member

/lgtm
/assign @detiber @gianarb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@detiber
Copy link
Member

detiber commented Jun 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 022e5e7 into kubernetes-sigs:master Jun 2, 2021
@cpanato cpanato deleted the tests-conformance branch June 2, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Conformance tests
5 participants