trigger finalizer even if the machine is already deleted from packet #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
requested changes
May 6, 2020
| return ctrl.Result{}, fmt.Errorf("error retrieving machine status %s: %v", packetmachine.Name, err) | ||
| } | ||
| if device == nil { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| if err.(*packngo.ErrorResponse).Response != nil && err.(*packngo.ErrorResponse).Response.StatusCode == http.StatusNotFound { | ||
| // When the server does not exist we do not have anything left to do. | ||
| // Probably somebody manually deleted the server from the UI or via API. | ||
| logger.Info("Server not found, nothig left to do") |
There was a problem hiding this comment.
Typo: "nothig" should be "nothing"
If we attempt to remove a machine that is not running on Packet (for any reason), we are in a loop where the reconciler returns 404 from Packet API and the source never gets deleted. This code should check for a 404, and it should pass forward the finalizer trigger a garbage collection. I presume we do not need to check for the number of `instances` anymore, because if they are `0` we never get over the `not found error`.
deitch
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we attempt to remove a machine that is not running on Packet (for any
reason), we are in a loop where the reconciler returns 404 from Packet
API and the source never gets deleted.
This code should check for a 404, and it should pass forward the
finalizer trigger a garbage collection.
I presume we do not need to check for the number of
instancesanymore,because if they are
0we never get over thenot found error.