Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set up default environment for kubectl, crictl, etc. #405

Merged
merged 4 commits into from
Sep 7, 2022
Merged

✨ Set up default environment for kubectl, crictl, etc. #405

merged 4 commits into from
Sep 7, 2022

Conversation

cprivitere
Copy link
Member

What this PR does / why we need it:
Update docker and k8s debian key registrations
Add crictl default container runtime configuration
Install kubetail on ubuntu 20+
export DEBIAN_FRONTEND=noninteractive once
Configure containerd to use Systemd cgroups
Configure containerd to use the pause image of installed k8s

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #403

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2022
Update docker and k8s debian key registrations
Add crictl default container runtime configuration
Install kubetail on ubuntu 20+
export DEBIAN_FRONTEND=noninteractive once
Configure containerd to use Systemd cgroups
Configure containerd to use the pause image of installed k8s

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@@ -146,6 +159,11 @@ spec:
systemctl restart networking
if [ -f "/run/kubeadm/kubeadm.yaml" ]; then
export KUBECONFIG=/etc/kubernetes/admin.conf
mkdir -p /root/.kube && cp -f $${KUBECONFIG} /root/.kube/config
echo "export KUBECONFIG=/etc/kubernetes/admin.conf" >> /root/.bashrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line in favor of the /root/.kube/config file

apt-get remove -y docker docker-engine docker.io containerd runc
apt-get install -y apt-transport-https ca-certificates curl gnupg lsb-release linux-generic jq
major_vers=$(lsb_release -r | awk '{ print $2 }' | cut -d. -f1)
if [[ "$major_vers" -ge 20 ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this is going to only work on Ubuntu

Fixes #403

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 7, 2022
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • c52c620 ✨ Set up default environment for kubectl, crictl, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cprivitere cprivitere merged commit 8c1784e into kubernetes-sigs:main Sep 7, 2022
@cprivitere cprivitere deleted the cprivitere/issue403 branch September 7, 2022 15:00
@cprivitere cprivitere restored the cprivitere/issue403 branch September 7, 2022 15:09
@cprivitere cprivitere deleted the cprivitere/issue403 branch September 7, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Set up default environment for kubectl, crictl, etc.
3 participants