kubelet runs on master #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the userdata currently it place in this PR the master gets a running kubelet. As reported on Jira, the kubelet is not running because we do not install a CNI yet, but this is not crucial at the moment. The userdata has some fixed values that we have to remove, like the ROLE. We will get there moving forward. I would like to fix the certificate issue first
|
I have a few questions with this.
|
deitch
reviewed
May 12, 2020
| @@ -175,13 +175,13 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s | |||
|
|
|||
| if !machineScope.Cluster.Status.InfrastructureReady { | |||
| machineScope.Info("Cluster infrastructure is not ready yet") | |||
| return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | |||
| return ctrl.Result{}, nil | |||
There was a problem hiding this comment.
Why do we no longer requeue? Don't we need to tell it to come back and queue up the request again? Or does the Machine controller change something on the PacketMachine when the cluster is ready? Something has to do it.
There was a problem hiding this comment.
copied it from aws. It works
| } | ||
|
|
||
| // Make sure bootstrap data secret is available and populated. | ||
| if machineScope.Machine.Spec.Bootstrap.DataSecretName == nil { | ||
| machineScope.Info("Bootstrap data secret is not yet available") | ||
| return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | ||
| return ctrl.Result{}, nil |
There was a problem hiding this comment.
copied it from aws. It works
There was a problem hiding this comment.
I don't have an answer even for the previous code
pkg/cloud/packet/scope/machine.go
Outdated
| secret := &corev1.Secret{} | ||
| key := types.NamespacedName{Namespace: m.Namespace(), Name: *m.Machine.Spec.Bootstrap.DataSecretName} | ||
| if err := m.client.Get(context.TODO(), key, secret); err != nil { | ||
| return nil, errors.Wrapf(err, "failed to retrieve bootstrap data secret for AWSMachine %s/%s", m.Namespace(), m.Name()) |
There was a problem hiding this comment.
I think you meant "PacketMachine"
deitch
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the userdata currently it place in this PR the master gets a
running kubelet.
As reported on Jira, the kubelet is not running because we do not
install a CNI yet, but this is not crucial at the moment.
The userdata has some fixed values that we have to remove, like the
ROLE. We will get there moving forward.
I would like to fix the certificate issue first