update example to use MachineDeployment #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
requested changes
May 12, 2020
templates/cluster-template.yaml
Outdated
| @@ -84,114 +84,74 @@ spec: | |||
| - "${SSH_KEY}" | |||
| tags: [] | |||
| --- | |||
| apiVersion: cluster.x-k8s.io/v1alpha3 | |||
| kind: Machine | |||
| apiVersion: cluster.x-k8s.io/v1alpha2 | |||
There was a problem hiding this comment.
Why is this v1alpha2? Should it not be v1alpha3?
templates/cluster-template.yaml
Outdated
| bootstrap: | ||
| configRef: | ||
| name: ${CLUSTER_NAME}-worker-a | ||
| apiVersion: bootstrap.cluster.x-k8s.io/v1alpha2 |
templates/cluster-template.yaml
Outdated
| kind: KubeadmConfigTemplate | ||
| infrastructureRef: | ||
| name: ${CLUSTER_NAME}-worker-a | ||
| apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2 |
The right way to go here is via MachineSet, MachineDeployment. Those are almost the equivalent of ReplicaSet and Deployment for pod. * MachineSet represents an immutable group of Machine * MachineDeployment manage the lifecycle of MachineSet I updated our example to use those for pod rollout. By consequence the example also uses KubeadmConfigTemplate and PacketMachineTemplate Control Plane management will come in another PR.
deitch
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right way to go here is via MachineSet, MachineDeployment.
Those are almost the equivalent of ReplicaSet and Deployment for pod.
I updated our example to use those for pod rollout.
By consequence the example also uses KubeadmConfigTemplate and
PacketMachineTemplate
Control Plane management will come in another PR.