✨ Update to Cluster API 1.6 #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
cprivitere
force-pushed
the
capi-1.6
branch
2 times, most recently
from
6ad4a57
to
aa55611
Compare
breaking: remove linux/armv7 builds cause they're slow
feat: profiling
- add flags for profiling
- process profiling and tls options
- NOTE: actual profiling may still need more work, this is mostly focused on handling flags
- add flags support for secure metrics server
- switch default metrics server to secured
refactor: main.go
- use infrav1 instead of infrav1beta1 in main.go
- functionize inits of webhooks, reconcilers and health checks in
- don't set ctrl options in line for better readability
- use caching for namespace watches
- process restconfig options
- e2e test signature update for 1.6 compatibility
refactor: machine controller and scope
- remove instance id
- get rid of getproviderid()
- add providerid()
- add deviceid which is providerid without prefix
- use deviceid for all api calls
- device/provider id usage now is more similar to upstream and other providers
fix: add RBAC rules for kubebuilder
fix: fix controller gen calls in makefile
- don't need two calls
- include main.go
- add cleanup like upstream has
fix: use real context in metal-go calls
doc: Add v0.8.x upgrade notes
chore: run make generate
chore: use new capi preferred api registration scheme
chore: use packet device id string as provider id (upstream removed noderefutil wrapped provider ids)
chore: metadata updates for 1.6 e2e tests
chore: bump calico to 3.27
chore: Bump kube-vip version to 0.6.4
chore: Bump CPEM to 3.7.0
chore: update readme explain tag changes
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
reviewed
Dec 20, 2023
displague
reviewed
Dec 20, 2023
|
|
||
| - `CPEM_VERSION` (defaults to `v3.7.0`) | ||
| - `KUBE_VIP_VERSION` (defaults to `v0.6.4`) | ||
| - `NODE_OS` (defaults to `ubuntu_20_04`) |
There was a problem hiding this comment.
noting that ubuntu_22_04 images had inconcistent package configurations - some with ifupdown others with netplan
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
reviewed
Dec 20, 2023
| @@ -436,7 +436,7 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s | |||
| result = ctrl.Result{} | |||
| default: | |||
| machineScope.SetNotReady() | |||
| log.Info("Equinix Metal device state is undefined", "state", dev.GetState(), "device-id", machineScope.GetInstanceID()) | |||
| log.Info("Equinix Metal device state is undefined", "state", dev.GetState(), "device-id", machineScope.ProviderID()) | |||
There was a problem hiding this comment.
nit: this could be .GetDeviceID() or log it as provider-id
(same on L410 and L414 above)
(looks like we already have the value in scope as deviceID, no need to call Provider() or GetDeviceID() again and again)
displague
reviewed
Dec 20, 2023
| // SchemeBuilder is used to add go types to the GroupVersionKind scheme. | ||
| SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion} | ||
| // schemeBuilder is used to add go types to the GroupVersionKind scheme. | ||
| schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) |
There was a problem hiding this comment.
This pattern and the changes to schemeBuilder, init, and objectTypes are documented at https://cluster-api.sigs.k8s.io/developer/providers/implementers-guide/create_api#registering-apis-in-the-scheme
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #687