Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base64 PACKET_API_KEY #96

Merged
merged 1 commit into from
Jun 1, 2020
Merged

add base64 PACKET_API_KEY #96

merged 1 commit into from
Jun 1, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented May 29, 2020

Fixed #95

@gianarb gianarb requested a review from deitch May 29, 2020 08:45
@gianarb gianarb mentioned this pull request May 29, 2020
Closed
@deitch
Copy link
Contributor

deitch commented May 31, 2020

You are right, that we are taking a raw key, but passing it to the secret as if it were base64 encoded; guaranteed to fail.

Do you think this is better than just setting it in the secret as stringData? That would be a bit more consistent with what we are used to, i.e. setting the key in an environment variable.

@gianarb gianarb merged commit e706602 into kubernetes-sigs:master Jun 1, 2020
@gianarb gianarb deleted the fix/credential-packet-api branch June 1, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PACKET_API_TOKEN is not base64 encoded
2 participants
@gianarb @deitch