New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure via make verify that generate cluster-templates are always up-to-date #2153

Closed

sbueringer opened this issue Aug 3, 2023 · 1 comment · Fixed by #2172

Member

sbueringer commented Aug 3, 2023

I think we should ensure via make verify on every PR that the generated cluster-templates in ./templates are up-to-date

Should ~ be:

create a target to run generate-flavors with templates as FLAVOR_DIR
add a corresponding verify target
Add the target to ALL_VERIFY_CHECKS

Member Author

sbueringer commented Aug 3, 2023

cc @chrischdi @killianmuldoon

sbueringer mentioned this issue

🌱 Add powerOffMode to templates #2149

Merged

laozc mentioned this issue

🌱 flavorgen generates all flavors by default #2172

Merged

k8s-ci-robot closed this as completed in #2172

laozc mentioned this issue

REQUEST: New membership for laozc kubernetes/org#4416

Closed

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment