Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 flavorgen generates all flavors by default #2172

Merged
merged 1 commit into from
Aug 9, 2023
Merged

🌱 flavorgen generates all flavors by default #2172

merged 1 commit into from
Aug 9, 2023

Conversation

laozc
Copy link
Member

@laozc laozc commented Aug 7, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2153

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2023
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit 👍

Makefile Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments.

Thanks for tackling this 👍

packaging/flavorgen/cmd/root.go Outdated Show resolved Hide resolved
packaging/flavorgen/cmd/root.go Outdated Show resolved Hide resolved
packaging/flavorgen/cmd/root.go Outdated Show resolved Hide resolved
@laozc laozc force-pushed the verify-flavor branch 2 times, most recently from 818cdaa to de084d0 Compare August 7, 2023 11:22
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really the last nits :-)

Makefile Outdated Show resolved Hide resolved
@laozc laozc force-pushed the verify-flavor branch 2 times, most recently from 565a7e0 to 671aea8 Compare August 8, 2023 05:25
chrischdi
chrischdi reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work!

Last round of improvements 👍

packaging/flavorgen/cmd/root.go Outdated Show resolved Hide resolved
packaging/flavorgen/cmd/root.go Outdated Show resolved Hide resolved
packaging/flavorgen/flavors/util/helpers.go Outdated Show resolved Hide resolved
@laozc laozc force-pushed the verify-flavor branch 2 times, most recently from 2b3581a to da80998 Compare August 8, 2023 07:03
chrischdi
chrischdi reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the patience :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a8ee34f9cd138cbdc552e35961cd046a3a0042e

@laozc
Copy link
Member Author

laozc commented Aug 8, 2023

LGTM label has been added.

Sure. Just feeling a bit scared when the CI is also not working :)

chrischdi
chrischdi reviewed Aug 8, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member

e2e main is currently broken due to the CI infrastructure.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 9, 2023 •
edited

@laozc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main 1070d27 link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

Thx!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fff1a64950e1c79dd2b8e12b5191cca1a06d0130

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87b8e93 into kubernetes-sigs:main Aug 9, 2023
10 of 11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Aug 9, 2023
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
0d9b88b 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
ddf7a5e 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
38ff53b 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@killianmuldoon @chrischdi
Grouped CI related cherry-picks
008d6b9 
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
This was referenced Aug 15, 2023
Merged
Merged
Merged
Merged
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@killianmuldoon @chrischdi
Grouped CI related cherry-picks
7909e05 
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
6f9dbf8 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
3dee688 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
70fb337 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
c981142 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
4b5d459 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
1e56730 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 15, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
53365cf 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 16, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
e3625da 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
chrischdi pushed a commit to chrischdi/cluster-api-provider-vsphere that referenced this pull request Aug 16, 2023
@lubronzhan @chrischdi
Grouped CI related cherry-picks
9ea224c 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
@laozc laozc mentioned this pull request Aug 29, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@MaxRink MaxRink Awaiting requested review from MaxRink

@yastij yastij Awaiting requested review from yastij

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Ensure via make verify that generate cluster-templates are always up-to-date
4 participants
@laozc @k8s-ci-robot @chrischdi @sbueringer