Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test #1269

Merged
merged 1 commit into from Oct 19, 2021
Merged

add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test #1269

merged 1 commit into from Oct 19, 2021

Conversation

aartij17
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AartiJivrajani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2021
@gab-satchi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2021
@aartij17
Copy link
Contributor Author

/retest

@aartij17 aartij17 force-pushed the v1beta1-cluster-update-test branch 8 times, most recently from 377d039 to 8246c6e Compare October 14, 2021 06:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
aartij17
aartij17 commented Oct 14, 2021
View reviewed changes
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2021
@yastij yastij mentioned this pull request Oct 18, 2021
Closed
7 tasks
@yastij
Copy link
Member

yastij commented Oct 18, 2021

/retest

@gab-satchi
Copy link
Member

/retitle add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test

@k8s-ci-robot k8s-ci-robot changed the title [WIP] add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test Oct 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2021
@gab-satchi
Copy link
Member

/test
pull-cluster-api-provider-vsphere-e2e

@k8s-ci-robot
Copy link
Contributor

@gab-satchi: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e
  • /test pull-cluster-api-provider-vsphere-test
  • /test pull-cluster-api-provider-vsphere-verify-crds
  • /test pull-cluster-api-provider-vsphere-verify-lint
  • /test pull-cluster-api-provider-vsphere-verify-markdown
  • /test pull-cluster-api-provider-vsphere-verify-shell

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-e2e
  • pull-cluster-api-provider-vsphere-test
  • pull-cluster-api-provider-vsphere-verify-crds
  • pull-cluster-api-provider-vsphere-verify-lint
  • pull-cluster-api-provider-vsphere-verify-shell

In response to this:

/test
pull-cluster-api-provider-vsphere-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gab-satchi
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e

@yastij
Copy link
Member

yastij commented Oct 18, 2021

/retest

@aartij17 @gab-satchi @yastij
add v1alpha3/v1alpha4->v1beta1 clusterctl upgrade test
91a2b5f 
Co-authored-by: Aarti <aartij17@gmail.com>
Co-authored-by: Gab Satchi <gsatchi@vmware.com>
@yastij yastij force-pushed the v1beta1-cluster-update-test branch from db2e2f9 to 91a2b5f Compare October 19, 2021 12:27
yastij
yastij approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks @AartiJivrajani @gab-satchi !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@yastij
Copy link
Member

yastij commented Oct 19, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ebdff7 into kubernetes-sigs:master Oct 19, 2021
This was referenced Oct 19, 2021
Closed
Closed
@aartij17 aartij17 mentioned this pull request Jan 27, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij approved these changes

@srm09 srm09 Awaiting requested review from srm09

Assignees

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aartij17 @k8s-ci-robot @gab-satchi @yastij