Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes clusterctl metadata for v1.1.x release #1465

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

nickperry
Copy link
Contributor

@nickperry nickperry commented Mar 8, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1464

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fix #1464 "clusterctl cannot find release 1.1.0" by adding missing 1.1 releaseseries data to metadata.yaml.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 8, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nickperry / name: Nick Perry (37055b3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @nickperry!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @nickperry. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

/retitle 🐛 Fixes clusterctl metadata for v1.1.x release
/ok-to-test

@k8s-ci-robot k8s-ci-robot changed the title Fix #1464 "clusterctl cannot find release 1.1.0" 🐛 Fixes clusterctl metadata for v1.1.x release Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

@nickperry you will need to sign the CLA and also edit the commit message to remove the Fix #<pr-number>

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 8, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

/check-cla

1 similar comment
@nickperry
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 8, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3629fcc into kubernetes-sigs:main Mar 8, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

/cherrypick release-1.1

1 similar comment
@srm09
Copy link
Contributor

srm09 commented Mar 8, 2022

/cherrypick release-1.1

k8s-ci-robot added a commit that referenced this pull request Mar 9, 2022
…stream-release-1.1

🐛 Automated cherry pick of #1465: Fixes clusterctl metadata for v1.1.x release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusterctl cannot find release 1.1.0
3 participants