Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Adds info to update metadata.yaml during release generation #1466

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented Mar 8, 2022

What this PR does / why we need it:
This updates the release doc to include the step to verify the presence of an entry in the metadata.yaml file when releasing a new minor version.

Which issue(s) this PR fixes:
Fixes #1464

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

This updates the release doc to include the step to verify the presence
of an entry in the `metadata.yaml` file when releasing a new minor
version.

Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2022
@srm09
Copy link
Contributor Author

srm09 commented Mar 8, 2022

/retitle 馃摉 Adds info to update metadata.yaml during release generation

@k8s-ci-robot k8s-ci-robot changed the title Adds info to update metadata.yaml 馃摉 Adds info to update metadata.yaml during release generation Mar 8, 2022
@MaxRink
Copy link
Contributor

MaxRink commented Mar 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@srm09
Copy link
Contributor Author

srm09 commented Mar 8, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit b0d077f into kubernetes-sigs:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusterctl cannot find release 1.1.0
3 participants