Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifier for CAPV credentials file #1506

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Add notifier for CAPV credentials file #1506

merged 1 commit into from
Apr 25, 2022

Conversation

scdubey
Copy link
Contributor

@scdubey scdubey commented Apr 5, 2022

Add filesystem watch on the file storing credentials for
capv-manager-bootstrap-credentials

Unit tests added

What this PR does / why we need it: This PR adds a filesystem Watch for the CAPV bootstrap credentials that updates the file under /etc/capv/credentials.yaml. If there's any update the manager is updated accordingly through the Watch events notifier.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1275

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @scdubey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2022
@yastij
Copy link
Member

yastij commented Apr 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
geetikabatra
geetikabatra reviewed Apr 6, 2022
View reviewed changes
pkg/manager/manager.go Outdated Show resolved Hide resolved
geetikabatra
geetikabatra suggested changes Apr 6, 2022
View reviewed changes
pkg/manager/manager.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
srm09
srm09 requested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to be failing with this change, could you make sure that there are green test runs before addressing the review comments.

pkg/manager/manager_test.go Show resolved Hide resolved
pkg/manager/manager_test.go Show resolved Hide resolved
pkg/manager/manager.go Outdated Show resolved Hide resolved
pkg/manager/manager_test.go Outdated Show resolved Hide resolved
pkg/manager/manager_test.go Outdated Show resolved Hide resolved
pkg/manager/manager_test.go Outdated Show resolved Hide resolved
@scdubey scdubey force-pushed the watch_capv_secret branch 5 times, most recently from 7d413a6 to ed07beb Compare April 22, 2022 01:41
srm09
srm09 reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits otherwise lgtm

pkg/manager/manager_test.go Outdated
@@ -0,0 +1,131 @@
/*
Copyright 2019 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2019 The Kubernetes Authors.
Copyright 2022 The Kubernetes Authors.

pkg/manager/manager_test.go Outdated Show resolved Hide resolved
pkg/manager/manager_test.go Show resolved Hide resolved
pkg/manager/manager_test.go Outdated Show resolved Hide resolved
pkg/manager/options.go Outdated
@@ -138,3 +136,9 @@ func (o *Options) getCredentials() map[string]string {

return credentials
}

func (o *Options) updateCredentials() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: more appropriate name for the function

Suggested change
func (o *Options) updateCredentials() {
func (o *Options) readAndSetCredentials() {

controllers/vmware/test/controllers_suite_test.go Show resolved Hide resolved
Add notifier for CAPV credentials file
00be337 
Add filesystem watch on the file storing credentials for
capv-manager-bootstrap-credentials

Unit tests added, Controller Suite tests updated
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 22, 2022 •
edited

@scdubey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-verify-shell b69c8d3 link true /test pull-cluster-api-provider-vsphere-verify-shell

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scdubey
Copy link
Contributor Author

scdubey commented Apr 22, 2022

/retest

@srm09
Copy link
Contributor

srm09 commented Apr 25, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2232d5f into kubernetes-sigs:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 requested changes

@geetikabatra geetikabatra geetikabatra requested changes

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@srm09 srm09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAPV manager should refresh and use new credentials if the bootstrap secret is updated
5 participants
@scdubey @k8s-ci-robot @yastij @srm09 @geetikabatra