馃悰 Fixes logic to fetch credentials of remote cluster #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
aartij17
force-pushed
the
fix-secret-lookup
branch
2 times, most recently
from
c5304dc
to
12306fa
Compare
|
/retest |
yastij
reviewed
Apr 19, 2022
|
/retest |
yastij
reviewed
Apr 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
srm09
force-pushed
the
fix-secret-lookup
branch
from
12306fa
to
dff8e37
Compare
k8s-ci-robot
added
size/XL
srm09
force-pushed
the
fix-secret-lookup
branch
from
dff8e37
to
15ab4c6
Compare
|
/retitle Fixes logic to fetch credentials of remote cluster |
k8s-ci-robot
changed the title
|
/retitle 馃悰Fixes logic to fetch credentials of remote cluster |
k8s-ci-robot
changed the title
|
/retitle 馃悰 Fixes logic to fetch credentials of remote cluster |
k8s-ci-robot
changed the title
The provider service account and service discovery controllers had an inherent assumption that the names of the Cluster and VSphereCluster object is the same. Hence the logic to fetch the secret containing the kubeconfig of the guest cluster was leveraging the name of the VSphereCluster object. With the advent of ClusterClass, the name of the generated VSphereCluster object is different than the name of the Cluster object. This patch adds the logic to get the owner Cluster object from the VSphereCluster object and use that to generate the name of the secret that contains the kubeconfig. It also updates the test logic by passing different name to the Cluster object. Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
fix-secret-lookup
branch
from
15ab4c6
to
46ca481
Compare
|
/lgtm |
|
@aartij17: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ClusterandVSphereClusterobject is the same which has changed with the advent ofClusterClass.Which issue(s) this PR fixes :
Fixes #1514
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: