Start the Keep Alive handler for VSphere client used in e2e tests #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srm09
added
kind/failing-test
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
fix-e2e/setup-and-terminate-session-with-handler
branch
from
aca12bd
to
0f2b832
Compare
k8s-ci-robot
added
size/S
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
yastij
reviewed
Apr 25, 2022
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some of the e2e test runs on testgrid keep failing due to failures in the test listed in
storage_policy_test.gofile. The reason for the failure is that the govmomi Client object we use to assert some conditions times out due to inactivity. As part of an earlier PR, aKeep-Alivehandler was added to the client which did not seem to solve the issue. The reason was that the groutine for the handler needs an explicit call toclient.Login()method to get activated.This patch slightly modifies the creation of the govmomi Client object and adds an explicit call to login after adding the keep alive handler and also logs out the session once the test is finished.
Which issue(s) this PR fixes:
n/a
Release note: