Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the keep-alive functionality out of the feature flag (+ deprecate the flag) #1522

Merged
merged 1 commit into from
May 4, 2022
Merged

Move the keep-alive functionality out of the feature flag (+ deprecate the flag) #1522

merged 1 commit into from
May 4, 2022

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented May 2, 2022 •
edited

What this PR does / why we need it:
We now use the keep-alive functionality by default, eliminating the need for it to be an opt-in flag. Thus this PR:

  • Deprecates the --enable-keep-alive command line flag.
  • Decouples the keep-alive functionality from the feature flag and removes the flag from the session-management feature config.
  • Updates controller-manager deployment manifests to reflect the flag's removal.

Which issue(s) this PR fixes
Fixes #1520

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ditsuke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from vrabbi and yastij May 2, 2022 15:52
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2022
@srm09
Copy link
Contributor

srm09 commented May 3, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@srm09
Copy link
Contributor

srm09 commented May 3, 2022

Can you squash and rebase the commits, this is ready to merge. Thanks for the quick turnaround on this one.

@ditsuke ditsuke force-pushed the deprecate-keep-alive-flag branch from 553d353 to 3c6e06f Compare May 4, 2022 08:38
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@ditsuke
Copy link
Contributor Author

ditsuke commented May 4, 2022

Can you squash and rebase the commits, this is ready to merge. Thanks for the quick turnaround on this one.

Done, thanks for reviewing

@geetikabatra
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@geetikabatra: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

srm09
srm09 reviewed May 4, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely sorry for this, I forgot that I had not posted this one. Just a couple of minor changes.

pkg/session/session.go Show resolved Hide resolved
pkg/session/session.go Outdated Show resolved Hide resolved
@ditsuke ditsuke force-pushed the deprecate-keep-alive-flag branch from 9d2098d to 23f4633 Compare May 4, 2022 19:45
@ditsuke @srm09
deprecate(flags): Factor out --enable-keep-alive flag
23f4633 
deprecate(flags): enable-keep-alive flag

The --enable-keep-alive flag is deprecated, since the functionality is now enabled by default.
IN subsequent commits the keep-alive feature's dependence on this flag will be factored out.

refactor: Decouple the keep-alive feature from the flag

With this commit, the deprecated keep-alive feature flag is functionally removed.
All functionality that previously relied on the flag's presence has been
refactored to work without the flag. The CLI flag is still present but marked
deprecated.

chore: Remove keep-alive flag from manager deployment manifest

The deprecated `--enable-keep-alive` is removed from the controller-manager's
deployment manifest.

chore: Update code comment in session/session

Co-authored-by: Sagar Muchhal <8758225+srm09@users.noreply.github.com>
@srm09
Copy link
Contributor

srm09 commented May 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6821812 into kubernetes-sigs:main May 4, 2022
@ditsuke ditsuke deleted the deprecate-keep-alive-flag branch May 6, 2022 16:41
@srm09 srm09 mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 left review comments

@vrabbi vrabbi Awaiting requested review from vrabbi

@yastij yastij Awaiting requested review from yastij

Assignees

@srm09 srm09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving the enable-keep-alive flag functionality out of a feature flag
4 participants
@ditsuke @k8s-ci-robot @srm09 @geetikabatra