馃尡 Updates CAPV manager cluster role #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This patch does the following two things: - Adds an aggregration rule for the CAPV manager role which can be used to add permissions to the manager role on the fly. External clients such as addons providers for CPI/CSI can use this label to add permissions to the manager dynamically, thereby reducing the need to hardcode these permissions in CAPV. - It also cleans up the patch files to add the CAPI and KCP aggregation labels to the CAPV manager role Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
add-capv-rbac-permissions
branch
from
b23f3f8
to
f0a3999
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
1 similar comment
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-vsphere-apidiff-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch adds an aggregration rule for the CAPV manager role which can be used to add permissions to the CAPV manager ClusterRole on the fly. External clients such as addons providers for CPI/CSI can use this label to add permissions to the manager dynamically, thereby reducing the need to hardcode these permissions in CAPV.
It also cleans up the patch files to add the CAPI and KCP aggregation labels to the CAPV manager role.
Which issue(s) this PR fixes:
Fixes #1526
Fixes #1523
Special notes for the reviewer:
The aggregation rule will help the clients creating ProviderServiceAccount objects to add the permissions specified in the
spec.Rulesfield to the CAPV manager ClusterRole. Without these permissions, the CAPV manager fails to create the role and role binding during the reconciliation of theProviderServiceAccountobject.Release note: