-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Moves vcsim builder code to remove cyclic dependency #1530
馃尡 Moves vcsim builder code to remove cyclic dependency #1530
Conversation
/assign @aartij17 |
/retest |
1 similar comment
/retest |
Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
d630f8b
to
6a2a84b
Compare
/lgtm |
/retest |
@srm09: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ignoring the apidiff failure here since all the changed types are only used for testing purposes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This patch moves the vcsim builder to a different package under
test/helpers
directory to remove cyclic dependency/Which issue(s) this PR fixes:
Fixes the issue raised in the PR comment
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: