Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Moves vcsim builder code to remove cyclic dependency #1530

Merged
merged 1 commit into from
May 11, 2022

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented May 10, 2022

What this PR does / why we need it:
This patch moves the vcsim builder to a different package under test/helpers directory to remove cyclic dependency/

Which issue(s) this PR fixes:
Fixes the issue raised in the PR comment

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@srm09 srm09 added this to the v1.2.0 milestone May 10, 2022
@srm09
Copy link
Contributor Author

srm09 commented May 10, 2022

/assign @aartij17

@srm09
Copy link
Contributor Author

srm09 commented May 10, 2022

/retest

1 similar comment
@srm09
Copy link
Contributor Author

srm09 commented May 10, 2022

/retest

Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
@aartij17
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2022
@srm09
Copy link
Contributor Author

srm09 commented May 11, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@srm09: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main 6a2a84b link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srm09
Copy link
Contributor Author

srm09 commented May 11, 2022

Ignoring the apidiff failure here since all the changed types are only used for testing purposes.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5d3c43a into kubernetes-sigs:main May 11, 2022
@srm09 srm09 deleted the refactor/session-tests branch June 15, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants