🐛 Delete node explicitly upon deletion of vm #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
cncf-cla: yes
aartij17
force-pushed
the
stale-node-deletion
branch
2 times, most recently
from
bf9b91e
to
d8f9588
Compare
This patch adds the logic to delete the k8s node from the cluster corresponding to the VM. This is necessary in cases where the node is never in the Ready state which leads to the node never getting removed from the cluster. This leads to a lot of stale nodes showing on the cluster with an active MHC. Co-authored by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
stale-node-deletion
branch
from
d8f9588
to
0030f1f
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
srm09
force-pushed
the
stale-node-deletion
branch
from
4594d99
to
6657871
Compare
Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
srm09
force-pushed
the
stale-node-deletion
branch
from
6657871
to
c35aeb1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @yastij |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 14, 2022
…lease-1.3 Automated cherry pick of #1551: Adds API group to e2e script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reaped nodes (which are Not Ready) by MHC show up in the output of kubectl get nodes. The name of the k8s node is same to the name of the owning CAPI Machine. This PR is a workaround which explicitly attempts to delete the node after the
VSphereVMdeletion. This PR builds on top of #1521Which issue(s) this PR fixes:
Fixes #1519
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: