Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for GPU with PCI #1571

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

geetikabatra
Copy link
Contributor

This PR adds documentation for GPU PCI implementation.

Signed-off-by: geetikab@vmware.com geetikab@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @geetikabatra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2022
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a lot of details to the document around the prerequisites for the cluster creation. Do accept the suggestions as a single commit.

docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Show resolved Hide resolved
docs/gpu-pci.md Show resolved Hide resolved
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some formatting changes, spell checks and reorganization.

docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
docs/gpu-pci.md Outdated Show resolved Hide resolved
@srm09
Copy link
Contributor

srm09 commented Jul 11, 2022

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
This PR adds documentation for GPU PCI implementation.

Signed-off-by: geetikab@vmware.com <geetikab@vmware.com>
Co-authored-by: Sagar Muchhal <8758225+srm09@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@srm09
Copy link
Contributor

srm09 commented Jul 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3e05202 into kubernetes-sigs:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants