Set VSphereMachine.Spec.Volumes zone annotation #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSI needs this annotation for PVC zone placement See: kubernetes-sigs/vsphere-csi-driver#1626 kubernetes-sigs/vsphere-csi-driver#1626
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dougm
added a commit
to dougm/cluster-api-provider-vsphere
that referenced
this pull request
Jul 27, 2022
The CSI zone annotation must be set when using a zonal storage class, which is required when the cluster has multiple (3) zones. Single zone clusters (legacy/default) do not support zonal storage and must not have the zone annotation set. See also: kubernetes-sigs#1573
dougm
added a commit
to dougm/cluster-api-provider-vsphere
that referenced
this pull request
Jul 27, 2022
The CSI zone annotation must be set when using a zonal storage class, which is required when the cluster has multiple (3) zones. Single zone clusters (legacy/default) do not support zonal storage and must not have the zone annotation set. See also: kubernetes-sigs#1573
dougm
added a commit
to dougm/cluster-api-provider-vsphere
that referenced
this pull request
Jul 27, 2022
The CSI zone annotation must be set when using a zonal storage class, which is required when the cluster has multiple (3) zones. Single zone clusters (legacy/default) do not support zonal storage and must not have the zone annotation set. See also: kubernetes-sigs#1573
srm09
pushed a commit
to srm09/cluster-api-provider-vsphere
that referenced
this pull request
Oct 20, 2022
The CSI zone annotation must be set when using a zonal storage class, which is required when the cluster has multiple (3) zones. Single zone clusters (legacy/default) do not support zonal storage and must not have the zone annotation set. See also: kubernetes-sigs#1573 (cherry picked from commit bca22f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI needs this annotation for PVC zone placement
See: kubernetes-sigs/vsphere-csi-driver#1626
kubernetes-sigs/vsphere-csi-driver#1626
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: