Use CloudInit bootstrap w VM Operator #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@srm09 / @yastij / @sidharthsurana, Do any of the three of you know whether the PR tests include validation against Supervisor and VM Operator integration? |
aruneshpa
approved these changes
Jul 22, 2022
akutz
force-pushed
the
feature/use-cloudinit-with-vmop
branch
from
1f6d7e3
to
e0d1d25
Compare
This patch updates CAPV to use the VM Operator CloudInit bootstrap method instead of ExtraConfig. This change ensures there is no race between VM Tools and CloudInit since using ExtraConfig will cause Guest OS Customization to configure the network, resulting in a reboot while CloudInit is running. Specifying CloudInit as the bootstrap provider ensures VM Operator uses CloudInit to bootstrap the network. Please note this patch will only work in vSphere 7P05+.
akutz
force-pushed
the
feature/use-cloudinit-with-vmop
branch
from
e0d1d25
to
8578ec0
Compare
bryanv
reviewed
Jul 22, 2022
bryanv
approved these changes
Jul 22, 2022
|
/lgtm We do not have the setup to test supervisor types in the upstream CI. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch updates CAPV to use the VM Operator CloudInit bootstrap method instead of ExtraConfig. This change ensures there is no race between VM Tools and CloudInit since using ExtraConfig will cause Guest OS Customization
to configure the network, resulting in a reboot while CloudInit is running. Specifying CloudInit as the bootstrap provider ensures VM Operator uses CloudInit to bootstrap the network.
Please note this patch will only work in vSphere 7P05+.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NA
Special notes for your reviewer:
This is required for uTKG.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: