Switch to CreateOrPatch; ignore manager binary at root of project #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I'll look into the test failure tomorrow and update the PR. |
akutz
force-pushed
the
feature/create-or-patch
branch
from
2fe21ec
to
10e5496
Compare
akutz
changed the title
This patch updates instances of CreateOrUpdate to CreateOrPatch in order to avoid being destructive during mutation of existing resources. This patch also updates the project's .gitignore file to ignore the manager binary that gets created at the root of the project if "go build" is used to build the manager.
akutz
force-pushed
the
feature/create-or-patch
branch
from
10e5496
to
43c56ad
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
bryanv
added a commit
to bryanv/cluster-api-provider-vsphere
that referenced
this pull request
Jul 27, 2022
When the switch to CreateOrPatch was added in kubernetes-sigs#1583, it supported merging the existing annotations: this is needed for certain LB like NSX-T which may add annotations - so remove leftover line setting the VirtualMachineService annotations.
srm09
added a commit
that referenced
this pull request
Oct 3, 2022
…lease-1.3 Automated cherry pick of #1583: Switch to CreateOrPatch; ignore manager binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch updates instances of CreateOrUpdate to CreateOrPatch in order to avoid being destructive during mutation of existing resources. This patch also updates a few instances of the
MutateFnto ensure labels/annotations/ownerrefs are updated instead of replaced when appropriate.This patch also updates the project's
.gitignorefile to ignore the manager binary that gets created at the root of the project ifgo buildis used to build the manager.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):None
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: