Reuse CAPI bootstrap secret with Supervisor

[akutz]

What this PR does / why we need it:

This patch removes the logic for creating a new ConfigMap resource for Supervisor VMs. Instead CAPV simply points the Supervisor resources to the existing CAPI bootstrap secrets.

Previously Supervisor integration required setting the ControlPlaneEndpoint value in Cloud-Init metadata.
However, this was recognized as vestigial as the KubeadmBootstrap controller automatically grabs the
ControlPlaneEndpoint from the Cluster.Spec.ControlPlaneEndpoint field if the value is not explicitly specified.

For more information please see the following links:

1. The CAPV Cluster reconciler does not proceed until there is a control plane endpoint

   cluster-api-provider-vsphere/controllers/vmware/vspherecluster_reconciler.go

   Lines 184 to 188 in cc73592

   	if ok, err := r.reconcileControlPlaneEndpoint(ctx); !ok {
   	if err != nil {
   	return reconcile.Result{}, errors.Wrapf(err, "unexpected error while reconciling control plane endpoint for %s", ctx.VSphereCluster.Name)
   	}
   	}

2. The CAPV Cluster reconciler sets Cluster.Spec.ControlPlaneEndpoint to the value of the load balancer

   cluster-api-provider-vsphere/controllers/vmware/vspherecluster_reconciler.go

   Lines 254 to 255 in cc73592

   	// If we've got here and we have a cpEndpoint, we're done.
   	ctx.VSphereCluster.Spec.ControlPlaneEndpoint = *cpEndpoint

3. The CAPV Cluster reconciler only marks the Cluster as "ready" when there is a valid control plane endpoint

   cluster-api-provider-vsphere/controllers/vmware/vspherecluster_reconciler.go

   Line 190 in cc73592

   ctx.VSphereCluster.Status.Ready = true

4. The CAPI Core KubeadmBootstrap reconciler does not proceed unless the Cluster is marked as "ready"
5. The CAPI Core KubeadmBootstrap reconciler uses the value of Cluster.Spec.ControlPlaneEndpoint if one is not provided explicitly
6. The CAPV Machine reconciler does not proceed until the bootstrap data is ready

   cluster-api-provider-vsphere/controllers/vspheremachine_controller.go

   Lines 292 to 302 in cc73592

   	// Make sure bootstrap data is available and populated.
   	if ctx.GetMachine().Spec.Bootstrap.DataSecretName == nil {
   	if !util.IsControlPlaneMachine(ctx.GetVSphereMachine()) && !conditions.IsTrue(ctx.GetCluster(), clusterv1.ControlPlaneInitializedCondition) {
   	ctx.GetLogger().Info("Waiting for the control plane to be initialized")
   	conditions.MarkFalse(ctx.GetVSphereMachine(), infrav1.VMProvisionedCondition, clusterv1.WaitingForControlPlaneAvailableReason, clusterv1.ConditionSeverityInfo, "")
   	return ctrl.Result{}, nil
   	}
   	ctx.GetLogger().Info("Waiting for bootstrap data to be available")
   	conditions.MarkFalse(ctx.GetVSphereMachine(), infrav1.VMProvisionedCondition, infrav1.WaitingForBootstrapDataReason, clusterv1.ConditionSeverityInfo, "")
   	return reconcile.Result{}, nil
   	}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
NA

Special notes for your reviewer:

Please note that I raised the failing go-apidiff test with @srm09 in internal Slack:

@akutz
I have no idea what make o-apidiff is or why it's causing a PR precheck to fail...

@srm09
apidiff just uses the same mechanism CAPI uses to figure out if any public facing method signatures get changed or removed. For the sake of consistency, this was done across all providers.

It is not a required check, so the PR should be ready to be merged even w/o it passing

Therefore it seems like we are okay moving ahead with this PR with that test failing. If anyone has any concerns, please let me know. Thanks!

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

* Supervisor integration no longer requires duplicating the bootstrap Secret resource as a plain-text ConfigMap resource.

[k8s-ci-robot]

@akutz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	4ca52b0	link	false	/test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[srm09]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [srm09]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment