Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Proposal for node anti affinity #1613

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented Sep 8, 2022

What this PR does / why we need it:
Proposal for node affinity and anti-affinity

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


/hold

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2022
Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
@srm09 srm09 force-pushed the proposal/node-affinity-aaf branch from dfec692 to 1f99746 Compare October 7, 2022 22:14
@srm09
Copy link
Contributor Author

srm09 commented Oct 7, 2022

/retitle 馃摉 Proposal for node anti affinity

@k8s-ci-robot k8s-ci-robot changed the title WIP: Proposal for node affinity & AAF 馃摉 Proposal for node anti affinity Oct 7, 2022
@srm09
Copy link
Contributor Author

srm09 commented Oct 7, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022
@srm09 srm09 marked this pull request as ready for review October 7, 2022 22:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2022
@yastij
Copy link
Member

yastij commented Oct 10, 2022

/approve
/lgtm

as this has been out for a month now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0464648 into kubernetes-sigs:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants