read failureReason and failureMessage from the vsphereVM object to the vspheremachine #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
yastij
force-pushed
the
fail-deleted-machines
branch
from
c707d04
to
feb701a
Compare
yastij
changed the title
ncdc
reviewed
Mar 17, 2020
akutz
approved these changes
Mar 17, 2020
andrewsykim
reviewed
Mar 17, 2020
yastij
force-pushed
the
fail-deleted-machines
branch
from
feb701a
to
e0334bc
Compare
andrewsykim
reviewed
Mar 17, 2020
yastij
force-pushed
the
fail-deleted-machines
branch
3 times, most recently
from
0a12aaf
to
22dae9c
Compare
…e vspheremachine Signed-off-by: Yassine TIJANI <ytijani@vmware.com> Co-authored-by: Naadir Jeewa <jeewan@vmware.com>
yastij
force-pushed
the
fail-deleted-machines
branch
from
22dae9c
to
2bae906
Compare
|
/lgtm Hi @yastij, Holding in case anyone else wants to make a final pass. |
k8s-ci-robot
added
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR ensures that we set the machines as failed when they are deleted from vcenter directly. remediation should happen through
MachineHealthChecksWhich issue(s) this PR fixes : Fixes #805
Special notes for your reviewer:
/cc @akutz @randomvariable
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: