🐛 [0.3] Scale down checks excludes machine about to be deleted #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the KCP controller crashes (likely in a self managed scenario) while other operations were in progress, at the next reconciliation loop the scale down operation would be blocked if for example we were in the middle of deleting etcd (which would also crash the api server) Signed-off-by: Vince Prignano <vincepri@vmware.com> (cherry picked from commit a284134) Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
ncdc
added
kind/bug
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
ncdc
commented
Dec 3, 2020
| fakeClient := newFakeClient(g, machines["one"], machines["two"], machines["three"]) | ||
|
|
||
| r := &KubeadmControlPlaneReconciler{ | ||
| Log: log.Log, |
There was a problem hiding this comment.
Note, I had to add this to avoid an NPE in preflightChecks constructing the logger
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the KCP controller crashes (likely in a self managed scenario) while
other operations were in progress, at the next reconciliation loop the
scale down operation would be blocked if for example we were in the
middle of deleting etcd (which would also crash the api server)
Signed-off-by: Vince Prignano vincepri@vmware.com
(cherry picked from commit a284134)
Backport of #3977
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #