-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring vertical autoscaling feature into current autoscaler. #19
Comments
There are at least 2 useful improvements that have been made to this horizontal autoscaler (#cores and a config file) that could be used for the vertical autoscaler. The code between the autoscaler and the rightsizer shouldn't need to be very different, and could live together. |
cc/ @mwielgus |
Another potential use-case for this is Calico, which currently uses some hard-coded scripting to ensure resources are set properly. Calico would want to make use of both the horizontal and vertical scaling features simultaneously. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
closes kubernetes-sigs#19 Signed-off-by: Dylan Page <genpage@pagefortress.com>
Although the original purpose of this repo is to provide a method for horizontal autoscaling, it would be great if we also bring in the vertical autoscaling feature, as this could be done in the same pattern. The vertical autoscaling feature could be modeled off of the Addon Resizer project, which is basically monitoring the cluster status and modify the scaling resource(like CPU and Memory resource in Deployment specs) as needed.
One thought is that we could implement vertical autoscaling controllers just like the horizontal ones. And we could also restructure the codes to enable running multiple controllers simultaneously (one scenario would be running one horizontal controller and one vertical controller together).
kube-dns
would be a real use case, as we may need to bump up its resource request when the cluster size grow big enough while we also want to horizontally scale it in the meantime.Another thought is we may need to collect different infos as the cluster status(rather than only number of nodes and cores) when different types of controllers start to come in. #10 may be a feasible starting point.
cc @bowei
The text was updated successfully, but these errors were encountered: