Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be a bit easier to setup webhook handlers without a manger #1255

Closed
DirectXMan12 opened this issue Nov 9, 2020 · 4 comments · Fixed by #1429
Closed

It should be a bit easier to setup webhook handlers without a manger #1255

DirectXMan12 opened this issue Nov 9, 2020 · 4 comments · Fixed by #1429
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@DirectXMan12
Copy link
Contributor

It's currently intended to be possible to set up webhook handlers w/o a manager (e.g. in your own HTTP mux, in a separate binary that doesn't need to have a REST config, etc), but it's not easy due to the dependency injection setup from the manager.

We should have a helper to make the dependencies more explicit, and to make this a bit easier.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2020
@kevindelgado
Copy link
Contributor

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@kevindelgado
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@DirectXMan12
Copy link
Contributor Author

I think there's two thing to care about here:

  • Can we set up a "normal" server without a manager / cluster connection information?
  • Can we attach controller-runtime webhooks to an existing arbitrary Go HTTP server (http.ServeMux) that's managing its own serving (i.e. not a webhook.Server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants