Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get test coverage for pkg/runtime to 100% #16

Closed
3 tasks
pwittrock opened this issue Jun 11, 2018 · 3 comments
Closed
3 tasks

Get test coverage for pkg/runtime to 100% #16

pwittrock opened this issue Jun 11, 2018 · 3 comments
Assignees

Comments

@pwittrock
Copy link
Contributor

  • signals
  • inject
  • log
@fanzhangio
Copy link

Sure

@fanzhangio
Copy link

Marked here as reference:

pkg/cache/informertest/fake_cache.go:45::warning: Errors unhandled.,LOW,HIGH (gas)
pkg/cache/informertest/fake_cache.go:54::warning: Errors unhandled.,LOW,HIGH (gas)
pkg/cache/informertest/fake_cache.go:67::warning: Errors unhandled.,LOW,HIGH (gas)
pkg/cache/informertest/fake_cache.go:82::warning: Errors unhandled.,LOW,HIGH (gas)
pkg/controller/controller_integration_test.go:114:4:warning: this value of newDeployment is never used (SA4006) (megacheck)
pkg/controller/controller_integration_test.go:144:4:warning: this value of newReplicaset is never used (SA4006) (megacheck)
pkg/handler/eventhandler_test.go:41:3:warning: this value of instance is never used (SA4006) (megacheck)
pkg/internal/admission/handler.go:37:18:warning: infinite recursive call (SA5007) (megacheck)
pkg/client/client.go:97:2:warning: should write resource := c.resourcesByType[typ] instead of resource, _ := c.resourcesByType[typ] (S1005) (megacheck)
pkg/controller/controller_test.go:97:6:warning: type injectable is unused (U1000) (megacheck)
pkg/internal/admission/handler.go:36:28:warning: func admissionHandler.handle is unused (U1000) (megacheck)
pkg/reconcile/example_test.go:41:7:warning: type MyReconcileImplementation is unused (U1000) (megacheck)

@pwittrock pwittrock added this to To do in Planned Work via automation Jun 13, 2018
@fanzhangio
Copy link

#34 Merged.

@fanzhangio fanzhangio mentioned this issue Jun 17, 2018
3 tasks
@pwittrock pwittrock moved this from To do to Done in Planned Work Jun 18, 2018
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
Clean up docs generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Planned Work
  
Done
Development

No branches or pull requests

2 participants