Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support configuring RecoverPanic globally #2001

Closed
mars1024 opened this issue Sep 15, 2022 · 1 comment · Fixed by #2093
Closed

support configuring RecoverPanic globally #2001

mars1024 opened this issue Sep 15, 2022 · 1 comment · Fixed by #2093
Assignees
@mars1024

Comments

@mars1024
Copy link
Contributor

Now RecoverPanic is only a field in controller.Options, if we want to enable this for all controllers, each controller initialization should be modified.

Since GroupKindConcurrency and CacheSyncTimeout can both be set through global v1alpha1.ControllerConfigurationSpec, IMO, RecoverPanic can do the same.

The only left problem is that RecoverPanic is bool type which has no zero-value, so maybe it has to be changed to pointer type, but i'm afraid this will be a break change.
@mars1024
Copy link
Contributor Author

/assign

@alvaroaleman alvaroaleman mentioned this issue Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mars1024 mars1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ Allow configuring RecoverPanic for controllers globally alvaroaleman/controller-runtime
1 participant
@mars1024