⚠️ Add client.{GroupVersionKindFor, IsObjectNamespaced} #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @alvaroaleman @sbueringer |
k8s-ci-robot
added
the
size/L
|
LGTM I required something like this in more than 1 place and it is definitely useful to see it provided by controller-runtime. |
sbueringer
reviewed
Jan 20, 2023
vincepri
force-pushed
the
enhance-client-interface
branch
from
6a54172
to
6a48014
Compare
sbueringer
reviewed
Jan 20, 2023
pkg/client/apiutil/apimachinery.go
Outdated
|
|
||
| // IsGVKNamespaced returns true if the object having the provided | ||
| // GVK is namespace scoped. | ||
| func IsGVKNamespaced(gvk schema.GroupVersionKind, scheme *runtime.Scheme, restmapper meta.RESTMapper) (bool, error) { |
There was a problem hiding this comment.
scheme is unused, maybe drop?
vincepri
force-pushed
the
enhance-client-interface
branch
from
6a48014
to
00bd96a
Compare
Add commonly used utilities that can be nicely wrapped in the built-in clients, in more details GroupVersionKindFor(obj) can be used to retrieve the GVK for a given object, while IsObjectNamespace can be used to determine if an object is global, or namespace scoped. Signed-off-by: Vince Prignano <vincepri@redhat.com>
vincepri
force-pushed
the
enhance-client-interface
branch
from
00bd96a
to
c783d25
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commonly used utilities that can be nicely wrapped in the built-in clients, in more details GroupVersionKindFor(obj) can be used to retrieve the GVK for a given object, while IsObjectNamespace can be used to determine if an object is global, or namespace scoped.
Signed-off-by: Vince Prignano vincepri@redhat.com