馃悰 Allow to set GracefulShutdownTimeout to -1, disabling timeouts #2169
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cherry-pick release-0.14 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @sbueringer |
Signed-off-by: Vince Prignano <vincepri@redhat.com>
vincepri
force-pushed
the
graceful-shutdown-1
branch
from
fb1d5d2
to
4272b5a
Compare
k8s-ci-robot
added
size/M
|
/cherry-pick release-0.14 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @alvaroaleman |
|
Looks good! /lgtm |
k8s-ci-robot
added
the
lgtm
|
@vincepri: new pull request created: #2198 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Vince Prignano vincepri@redhat.com
This is already specified in the documentation https://github.com/kubernetes-sigs/controller-runtime/blob/v0.14.1/pkg/manager/manager.go#L293
Fixes #2110