✨ Cleanup webhook logging #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
sbueringer
commented
May 15, 2023
sbueringer
force-pushed
the
pr-cleanup-webhook-logging
branch
3 times, most recently
from
d03a406
to
f36694d
Compare
FillZpp
reviewed
May 15, 2023
sbueringer
force-pushed
the
pr-cleanup-webhook-logging
branch
from
f36694d
to
0f47d28
Compare
sbueringer
commented
May 15, 2023
| @@ -69,7 +69,7 @@ func (wh *Webhook) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| // verify the content type is accurate | |||
| if contentType := r.Header.Get("Content-Type"); contentType != "application/json" { | |||
| err = fmt.Errorf("contentType=%s, expected application/json", contentType) | |||
| wh.getLogger(nil).Error(err, "unable to process a request with an unknown content type", "content type", contentType) | |||
| wh.getLogger(nil).Error(err, "unable to process a request with unknown content type") | |||
There was a problem hiding this comment.
content type is already contained in the error + we don't need it as separate k/v pair for log filtering
sbueringer
commented
May 15, 2023
| @@ -93,7 +93,7 @@ func (wh *Webhook) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| wh.writeResponse(w, reviewResponse) | |||
| return | |||
| } | |||
| wh.getLogger(nil).V(1).Info("received request", "UID", req.UID, "kind", req.Kind, "resource", req.Resource) | |||
| wh.getLogger(&req).V(1).Info("received request") | |||
There was a problem hiding this comment.
k/v pairs are added by getLogger, kind is not needed as we already have webhookKind
|
@FillZpp should be removed /assign @FillZpp @alvaroaleman |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes UID consistently to requestID + some smaller cleanups.
Result logs look like this: