馃尡 Minor improvements to godoc, code style in builder pkg #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
sbueringer
force-pushed
the
pr-minor-builder
branch
2 times, most recently
from
1bf3b8e
to
94e5a8e
Compare
k8s-ci-robot
added
size/M
inteon
reviewed
Jul 22, 2023
sbueringer
force-pushed
the
pr-minor-builder
branch
from
94e5a8e
to
a2fbadd
Compare
sbueringer
commented
Jul 22, 2023
| @@ -274,7 +274,8 @@ func (blder *Builder) doWatch() error { | |||
| } | |||
| src := source.Kind(blder.mgr.GetCache(), obj) | |||
| hdler := &handler.EnqueueRequestForObject{} | |||
| allPredicates := append(blder.globalPredicates, blder.forInput.predicates...) | |||
| allPredicates := append([]predicate.Predicate(nil), blder.globalPredicates...) | |||
There was a problem hiding this comment.
Just aligning to the way we do it below. I played a bit around with it, I don't think it makes a difference
alvaroaleman
approved these changes
Jul 24, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Should be an independent flake /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.