Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ builder: return error when multiple reconcilers are set #2415

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 22, 2023

Just saw this and was confused why we would want this behavior. I also looked at #1021 but I don't understand the reasoning.

If we want a silent overwrite behavior I would have expected Build/Complete to overwrite the reconciler from the previous set ctrlOptions not the other way around

I think this implementation still covers the original ask, folks can pass in a nil reconciler to Build/Complete

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2023
@FillZpp
Copy link
Contributor

FillZpp commented Jul 24, 2023

Sounds good, but not sure if someones have already relied on the behavior that c-r will use the reconciler in options first with no error?

@sbueringer
Copy link
Member Author

Sounds good, but not sure if someones have already relied on the behavior that c-r will use the reconciler in options first with no error?

I would assume that if they do they would get an error now and then can decide which reconciler they want to use. If they want to keep using the one from options it should be trivial to pass in "nil" into Build/Complete

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e644e50 into kubernetes-sigs:main Jul 26, 2023
21 checks passed
@sbueringer sbueringer deleted the pr-minor-builder-multi branch July 26, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants