Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ Remove deprecated Defaulter and Validator interfaces #2877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚠ Remove deprecated Defaulter and Validator interfaces #2877

wants to merge 1 commit into from
+5 −1,224

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jul 8, 2024 •
edited
Loading

We deprecated the admission.Validator and the admission.Defaulter interfaces and these are said to be removed in release-0.19.

Closes #2641

  • Remove deprecated interfaces
  • Remove tests for those types
  • Change log message that point to the now removed interfaces for the builder.
  • Moved type Warnings to validator_custom.go

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2024
@troy0820
remove deprecated Defaulter and Validator interfaces
ebdc829 
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-webhooks branch from 1c3cb32 to ebdc829 Compare July 8, 2024 16:27
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 8, 2024 •
edited
Loading

@troy0820: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff ebdc829 link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

@troy0820 can you remind me where we said we're going to remove them with 0.19?

IIRC it was on some issue, can you please link it in the PR description?

That being said, not sure when we should do it. I think this will require a lot of folks to make changes, maybe we should give them more time. I don't think we have anything pressing that requires us to drop them very soon.

@vincepri @alvaroaleman wdyt?

@troy0820
Copy link
Member Author

troy0820 commented Jul 9, 2024

can you remind me where we said we're going to remove them with 0.19?
IIRC it was on some issue, can you please link it in the PR description?

Updated the PR description with the issue.

That being said, not sure when we should do it. I think this will require a lot of folks to make changes, maybe we should give them more time. I don't think we have anything pressing that requires us to drop them very soon.

I’m not in any rush to remove them but it was put against the v0.19 milestone. We can wait if the changes need to be made other places as well as give people more time.

@troy0820 troy0820 mentioned this pull request Jul 9, 2024
Open
@k8s-ci-robot
Copy link
Contributor

@grzesuav: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grzesuav, troy0820
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzesuav grzesuav grzesuav approved these changes

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated webhook interfaces
4 participants
@troy0820 @k8s-ci-robot @sbueringer @grzesuav