⚠ admission.Decoder is now an interface #2736
Conversation
k8s-ci-robot
added
approved
The current implementation allows to create a decoder without
a scheme/codecs by just referencing the struct `&admission.Decoder{}`
given that codecs is private. The field was filled in before with the
inject package which has been removed. This change retains the Decoder
definition and makes it an interface, `admission.NewDecoder(scheme)` is
now the only way to instantiate our default decoder.
Signed-off-by: Vince Prignano <vincepri@redhat.com>
k8s-ci-robot
added
the
size/M
vincepri
force-pushed
the
decoder-interface
branch
from
d557775
to
04c37a9
Compare
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The controller-manager won't automatically inject decoder to webhook handler in new implementation, which will cause the panic error of webhook. Use admission.NewDecoder(scheme) instead as it is now the only way to instantiate default decoder. kubernetes-sigs/controller-runtime#2736
The current implementation allows to create a decoder without a scheme/codecs by just referencing the struct
&admission.Decoder{}given that codecs is private. The field was filled in before with the inject package which has been removed. This change retains the Decoder definition and makes it an interface,admission.NewDecoder(scheme)is now the only way to instantiate our default decoder.Fixes #2695