Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Modules: Downstream project is breaking due to move of github.com/appscode/jsonpatch #500

Closed
connor1989 opened this issue Jun 25, 2019 · 10 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@connor1989
Copy link

Downstream projects using go modules are running into issues since com/appscode/jsonpatch has moved to github.com/gomodules/jsonpatch. Not sure if this is user error with go mod's. It's also worth mentioning the update occurred today.

Ex output:

go: finding github.com/appscode/jsonpatch latest
go: downloading github.com/appscode/jsonpatch v0.0.0-20190625112030-8287e15e901f
build command-line-arguments: cannot load github.com/appscode/jsonpatch: cannot find module providing package github.com/appscode/jsonpatch

Env:
go version go1.12.5 darwin/amd64

@connor1989
Copy link
Author

/priority important-longterm
/kind bug

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/bug Categorizes issue or PR as related to a bug. labels Jun 25, 2019
@lli-hiya
Copy link

I am seeing exactly the same issue. Any workaround?

@Jingru
Copy link

Jingru commented Jun 28, 2019

Same issue here.

@DirectXMan12
Copy link
Contributor

should've just been fixed by #499

@ghostsquad
Copy link

I'm still having this problem.

go: finding sigs.k8s.io/controller-runtime/pkg/log/zap latest
go: finding sigs.k8s.io/controller-runtime/pkg/log latest
go: finding sigs.k8s.io/controller-runtime/pkg latest
build myproject: cannot load github.com/appscode/jsonpatch: cannot find module providing package github.com/appscode/jsonpatch

what am I doing wrong?

@alastor-erinyes
Copy link

I hit this same issue as well.

go: extracting github.com/gomodules/jsonpatch v2.0.0+incompatible
go: finding github.com/appscode/jsonpatch v2.0.0+incompatible
go: finding sigs.k8s.io/controller-runtime/pkg/log latest
go: finding sigs.k8s.io/controller-runtime/pkg latest
build github.com/datarobot/DataRobot/execute/golang/testbin: cannot load github.com/appscode/jsonpatch: cannot find module providing package github.com/appscode/jsonpatch

I've tried a few replace directives in go.mod, but nothing is working so far.

@fspaniol
Copy link

fspaniol commented Aug 1, 2019

Was trying to follow this: https://book.kubebuilder.io/quick-start.html#create-a-project and faced the same issue:

kubebuilder init --domain fernando
go mod tidy
go: finding sigs.k8s.io/controller-runtime v0.2.0-beta.4
go: finding github.com/evanphx/json-patch v4.5.0+incompatible
go: gomodules.xyz/jsonpatch/v2@v2.0.0: unrecognized import path "gomodules.xyz/jsonpatch/v2" (https fetch: Get https://gomodules.xyz/jsonpatch/v2?go-get=1: net/http: TLS handshake timeout)
go: error loading module requirements
2019/08/01 15:07:19 exit status 1

Manually changing to beta.2 in go.mod did the trick.

@DirectXMan12
Copy link
Contributor

@fspaniol probably a blip in that module's hosting. Cannot reproduce now.

@sara4dev
Copy link

I still seeing the same error.

build command-line-arguments: cannot load github.com/appscode/jsonpatch: module github.com/appscode/jsonpatch@latest found (v2.0.1+incompatible), but does not contain package github.com/appscode/jsonpatch

@DirectXMan12
Copy link
Contributor

make sure you don't have the old version in your go.mod

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
Put the manager binary into /, instead of /root/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

9 participants