Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Actually inject the scheme in StandaloneWebhook #1490

Merged
merged 1 commit into from Apr 23, 2021
Merged

🐛 Actually inject the scheme in StandaloneWebhook #1490

merged 1 commit into from Apr 23, 2021

Conversation

kevindelgado
Copy link
Contributor

Fixes a bug from #1429 where StandaloneWebhook never injects the scheme and refactors the FakeValidator so it can be used to test StandaloneWebhook

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2021
@kevindelgado
Copy link
Contributor Author

/assign @DirectXMan12

@kevindelgado
Copy link
Contributor Author

/cc @stevekuznetsov

@kevindelgado kevindelgado mentioned this pull request Apr 23, 2021
Merged
@kevindelgado kevindelgado force-pushed the standalone-webhooks-fix-scheme branch from 991366f to 1cc4d1a Compare April 23, 2021 02:09
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2021
@kevindelgado kevindelgado force-pushed the standalone-webhooks-fix-scheme branch from 1cc4d1a to 19168b3 Compare April 23, 2021 02:16
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, kevindelgado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit b2c90ab into kubernetes-sigs:master Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.9.x milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@joelanford joelanford Awaiting requested review from joelanford

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevindelgado @DirectXMan12 @k8s-ci-robot