🐛 Serve metrics even if not leader

[JoelSpeed]

Fixes #196.

Move metrics serving to before we separate into the leader election vs non leader election start process.

This allows prometheus to count non-leader targets as up, but will just receive an empty response for non-leaders and so no inaccurate metrics are collected.

[DirectXMan12]

/kind bug
/priority important-soon

[DirectXMan12]

I think this LGTM.

Looks like the test issue is in the metrics test: https://travis-ci.org/kubernetes-sigs/controller-runtime/jobs/450256058#L617

[DirectXMan12]

Looks like it's affecting multiple PRs (e.g. #193). I'd guess it's a flake. I'm going to fork off a separate bug.

[JoelSpeed]

@DirectXMan12 I've rebased this now #200 is merged, tests are passing now

[DirectXMan12]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DirectXMan12]

looks like there's a merge conflict. rebase and we'll get this merged.

[JoelSpeed]

@DirectXMan12 Rebased, should be good to go now

[DirectXMan12]

/lgtm